Fix MinGW target detection in raw-dylib #94365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM target doesn't have to be the same as Rust target so relying on it is wrong.
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @ricobbe |
|
Thanks for the heads-up; this looks entirely reasonable to me. |
|
📌 Commit c35a1d4 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 28, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#89793 (Add `slice::{from_ptr_range, from_mut_ptr_range} `) - rust-lang#92642 (Update search location from a relative path to absolute) - rust-lang#93389 (regression for issue 90847) - rust-lang#93413 (Fix broken link from rustdoc docs to ayu theme) - rust-lang#94365 (Fix MinGW target detection in raw-dylib) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM target doesn't have to be the same as Rust target so relying on it is wrong.
It was one of concerns in #88801 that was not fixed in #90782.